ui: add CPU column on Insights #96279
Conversation
|
This change is |
maryliag
force-pushed
the
cpu-insight-ui
branch
from
3120808 to
fff0785
Compare
There was a problem hiding this comment.
LGTM!
Reviewed 7 of 7 files at r1, 24 of 24 files at r2, 9 of 9 files at r3, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @maryliag)
pkg/ui/workspaces/cluster-ui/src/insights/types.ts line 33 at r3 (raw file):
application: string; contentionTime?: moment.Duration; cpuNanos: number;
Just to clarify, the change to cpuSQLNanos was only to be reflected on the sql package for crdb_internal and system tables for stmt statistics right? And when it comes to the naming in the UI package, cpuNanos should remain as-is?
Explained offline, but yes, the naming change is to reflect that the stats saved are for sql cpu only, but on the UI we will continue to call it just CPU |
maryliag
force-pushed
the
cpu-insight-ui
branch
from
fff0785 to
7276f26
Compare
I might suggest still calling it |
Part Of cockroachdb#87213 Adds CPU Time column on Statement and Transaction Insights pages and their respective details pages. Release note (ui change): Add CPU Time to Statement and Transaction Insights.
maryliag
force-pushed
the
cpu-insight-ui
branch
from
7276f26 to
06838a1
Compare
There was a problem hiding this comment.
Done
Reviewable status:
There was a problem hiding this comment.
Reviewed 8 of 8 files at r5, all commit messages.
Reviewable status:
|
TFTR! |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Part Of #87213
Adds CPU Time column on Statement and Transaction
Insights pages and their respective details pages.
Transaction Overview
Transaction Details
Statements Overview
Statement Details
Release note (ui change): Add CPU Time to Statement and
Transaction Insights.