sql/schemachanger: forward fit compatibility changes for 22.2 rules #96273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fqazi
force-pushed
the
reforwardFitRules
branch
2 times, most recently
from
4d26906 to
a420256
Compare
Previously, some of the constraint related rules in the 22.2 set were incorrectly using logic for 23.X. This patch addresses those to get compatibility back. Additionally, some minor clean up in rules related helpers to ensure proper compatibility. With this change a manual diff shows both branches are now equal in terms of rules. Epic: none Release note: None
fqazi
force-pushed
the
reforwardFitRules
branch
from
a420256 to
372b2f4
Compare
I'd like us to keep using the same names from one version to the next. I think it's fine to backport rule name changes from master into 22.2 to achieve this. |
postamar
approved these changes
Feb 1, 2023
This is linked to element renames, but I think this is fine to backport it doesn't impact binary compatibility either. I'll backport that stuff as a part of the roachtest work (debug command + test). @postamar TFTR! |
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs: #95849
Previously, some constraint-related rules in the 22.2 set incorrectly used logic for 23.X. This patch addresses those to get compatibility back. Additionally, some minor clean-up in rules-related helpers to ensure proper compatibility.
With this change, a manual diff shows both branches are now equal in terms of rules (outside of renames). A roachtest will be coming soon to assert this.
Epic: none
Release note: None