Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: workload: use different random seeds by default #95695

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

renatolabs
Copy link
Contributor

Backport 1/1 commits from #95326.

/cc @cockroachdb/release


This changes most of the workloads that take a --seed command line flag so that they use a different, randomly generated seed on each run. Previously, they would all default to 1, making every run of the workload produce the same data and operations. That behavior is good for reproducing a specific pattern or behavior, but workloads that have a random element should exploit that randomness by default.

When a workload is invoked, a random seed is generated and logged. Users are still able to specify their own seeds by passing the --seed flag.

Resolves #88566.

Release note (cli change): workloads that take a --seed argument
used to default to 1. Now, they use a randomly generated seed in
each run. Users can still pass a custom seed with the --seed flag.

@renatolabs renatolabs requested review from a team and herkolategan and removed request for a team January 23, 2023 20:15
@renatolabs renatolabs requested a review from a team as a code owner January 23, 2023 20:15
@renatolabs renatolabs requested a review from smg260 January 23, 2023 20:15
@blathers-crl
Copy link

blathers-crl bot commented Jan 23, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@srosenberg srosenberg self-requested a review February 28, 2023 03:47
This changes most of the workloads that take a `--seed` command line
flag so that they use a different, randomly generated seed on each
run.  Previously, they would all default to `1`, making every run of
the workload produce the same data and operations. That behavior is
good for reproducing a specific pattern or behavior, but workloads
that have a random element should exploit that randomness by
default.

When a workload is invoked, a random seed is generated and
logged. Users are still able to specify their own seeds by passing the
`--seed` flag.

Resolves cockroachdb#88566.

Release note (cli change): workloads that take a `--seed` argument
used to default to `1`. Now, they use a randomly generated seed in
each run. Users can still pass a custom seed with the `--seed` flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants