Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: gossip: don't resolve addresses while holding mutex #95443

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 18, 2023

Backport 1/1 commits from #95426 on behalf of @erikgrinaker.

/cc @cockroachdb/release


This patch removes a DNS resolution call performed while holding the gossip mutex. This can lead to severe process stalls if the DNS lookup is not immediate, since we need to acquire gossip read locks in several performance critical code paths, including Raft processing. However, the DNS lookup was only done when validating a remote forwarding address, which presumably happens fairly rarely. Removing it should not cause any problems, since the address will necessarily be validated later when attempting to connect to it.

Epic: none
Release note (bug fix): Fixed a bug where a DNS lookup was performed during gossip remote forwarding while holding the gossip mutex. This could cause processing stalls if the DNS server was slow to respond.


Release justification:

This patch removes a DNS resolution call performed while holding the
gossip mutex. This can lead to severe process stalls if the DNS lookup
is not immediate, since we need to acquire gossip read locks in several
performance critical code paths, including Raft processing. However, the
DNS lookup was only done when validating a remote forwarding address,
which presumably happens fairly rarely. Removing it should not cause any
problems, since the address will necessarily be validated later when
attempting to connect to it.

Epic: none
Release note (bug fix): Fixed a bug where a DNS lookup was performed
during gossip remote forwarding while holding the gossip mutex. This
could cause processing stalls if the DNS server was slow to respond.
@blathers-crl blathers-crl bot requested a review from a team as a code owner January 18, 2023 17:11
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-95426 branch from 5c593c9 to 19169d0 Compare January 18, 2023 17:11
@blathers-crl blathers-crl bot requested a review from tbg January 18, 2023 17:11
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 18, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Jan 18, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker merged commit d381f52 into release-22.2 Jan 23, 2023
@erikgrinaker erikgrinaker deleted the blathers/backport-release-22.2-95426 branch January 23, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants