builtins: implement pg_table_is_visible as UDF #94339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
force-pushed
the
sql-pg-table-is-vibisl
branch
from
dab9289 to
cb153a4
Compare
|
UDF team - is this a valid thing to do? Do you understand why the performance would be improved? @mgartner @chengxiong-ruan |
mgartner
approved these changes
Dec 27, 2022
jordanlewis
force-pushed
the
sql-pg-table-is-vibisl
branch
from
cb153a4 to
d29ac16
Compare
rafiss
requested changes
Dec 28, 2022
jordanlewis
force-pushed
the
sql-pg-table-is-vibisl
branch
from
d29ac16 to
3028f15
Compare
|
Done |
rafiss
approved these changes
Dec 29, 2022
jordanlewis
force-pushed
the
sql-pg-table-is-vibisl
branch
3 times, most recently
from
d8d7c32 to
4a472d5
Compare
rafiss
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis)
pkg/sql/pg_catalog.go line 3335 at r1 (raw file):
// table. We have special logic for this case. if typDesc.GetKind() == descpb.TypeDescriptor_TABLE_IMPLICIT_RECORD_TYPE { table, err := p.Descriptors().GetImmutableTableByID(ctx, p.txn, id, tree.ObjectLookupFlags{})
does this part also need to check for dropped tables?
jordanlewis
force-pushed
the
sql-pg-table-is-vibisl
branch
from
4a472d5 to
86ed161
Compare
jordanlewis
commented
Dec 29, 2022
There was a problem hiding this comment.
Reviewable status:
pkg/sql/pg_catalog.go line 3335 at r1 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
does this part also need to check for dropped tables?
Good point, fixed
rafiss
approved these changes
Dec 29, 2022
postamar
reviewed
Jan 2, 2023
| @@ -175,7 +175,6 @@ func (v TableImplicitRecordType) Adding() bool { | |||
|
|
|||
| // Dropped implements the Descriptor interface. | |||
| func (v TableImplicitRecordType) Dropped() bool { | |||
| v.panicNotSupported("Dropped") | |||
| return false | |||
There was a problem hiding this comment.
Shouldn't this instead delegate to the wrapped table descriptor?
jordanlewis
force-pushed
the
sql-pg-table-is-vibisl
branch
from
86ed161 to
2404b3f
Compare
Previously, the pg_proc and pg_type virtual indexes would show cross-db objects, which is not supposed to happen. This is now corrected. Release note (bug fix): the pg_proc and pg_type virtual oid indexes no longer incorrectly show cross-db objects. This is unlikely to affect real-world use cases.
Now that we support UDFs, we can implement builtin functions as "virtual
UDFs", that are defined in the builtins map.
The builtin appears to be about twice as fast with this method, which is
nice because it gets used a lot in ORM introspection queries.
Epic: None
Release note (performance improvement): improve the performance of
pg_{function,table,type}_is_visible
Co-authored-by: rafiss <[email protected]>
Release note: None
jordanlewis
force-pushed
the
sql-pg-table-is-vibisl
branch
from
2404b3f to
d363b40
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we support UDFs, we can implement builtin functions as "virtual
UDFs", that are defined in the builtins map.
The builtin appears to be about twice as fast with this method, which is
nice because it gets used a lot in ORM introspection queries.
Release note (performance improvement): improve the performance of
pg_table_is_visible
Epic: None
Co-authored-by: rafiss [email protected]