sql: implement the pg_timezone_names table #94122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
14 tasks
otan
force-pushed
the
pg_timezone_names
branch
from
1acd324 to
09c571e
Compare
rafiss
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
this is timely! we just got cockroachdb/docs#15873, and looks like this will resolve it
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @otan)
pkg/sql/pg_catalog.go line 4154 at r1 (raw file):
func addRowForTimezoneNames(tz string, t time.Time, addRow func(...tree.Datum) error) error { abbrev, offset := t.Zone() d := duration.MakeDuration(int64(offset)*int64(time.Second), 0, 0)
what is this multiplication meant to calculate?
pkg/sql/pg_catalog.go line 4159 at r1 (raw file):
tree.NewDString(abbrev), // abbrev tree.NewDInterval(d, types.DefaultIntervalTypeMetadata), // utc_offset tree.MakeDBool(tree.DBool(t.IsDST())), // is_dist
nit: comment should be is_dst
otan
force-pushed
the
pg_timezone_names
branch
3 times, most recently
from
86564a0 to
4bfa781
Compare
|
bors r=rafiss |
|
Merge conflict. |
Release note (sql change): Implement the `pg_timezone_names` pg_catalog table, which lists all supported timezones.
otan
force-pushed
the
pg_timezone_names
branch
from
4bfa781 to
e1be665
Compare
|
bors r=rafiss |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #84505
Release note (sql change): Implement the
pg_timezone_namespg_catalog table, which lists all supported timezones.