streamingccl: add WITH RETENTION option to CREATE TENANT #94001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
lidorcarmel
approved these changes
Dec 20, 2022
| { | ||
| $$.val = $2.tenantReplicationOptions() | ||
| } | ||
| | WITH OPTIONS '(' tenant_replication_options_list ')' |
There was a problem hiding this comment.
so we can also do CREATE TENANT .. FROM REPLICATION OF .. ON .. WITH OPTIONS (RETENTION = 36h); right? can you add a test for that syntax? or maybe we can wait for the data driven tests for that?
btw is that standard to support both WITH X = y and WITH OPTIONS (X = y)?
There was a problem hiding this comment.
Added a parser test.
The WITH OPTIONS (X =y) is also supported by BACKUP and RESTORE so I supported it here for consistency.
This adds an WITH RETENTION = 'duration' option to CREATE TENANT to allow the user to set the retention window at replication stream creation time. A future commit will support updating this option via SET as well. Informs: cockroachdb#93441 Release note: None
stevendanna
force-pushed
the
create-tenant-with-retention
branch
from
1ab6b74 to
16ed89c
Compare
|
bors r=lidorcarmel |
|
Build succeeded: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an WITH RETENTION = 'duration' option to CREATE TENANT to allow the user to set the retention window at replication stream creation time.
A future commit will support updating this option via SET as well.
Informs: #93441
Release note: None