-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: degrade gracefully when regions aren't known #93985
ui: degrade gracefully when regions aren't known #93985
Conversation
Bazel Extended CI failures are unrelated, fallout from #93754, fixed in #94005.
|
Part of #89949 Previously, when a tenant SQL instance had spun down (leaving us no way to remember which region it had been in), the SQL Activity pages would claim that statements and transactions had occurred in an "undefined" region. This change moves from saying "undefined" to saying nothing at all, a slightly nicer user experience. This broader problem of losing the region mapping has been described in #93268; we'll begin addressing it shortly. Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any way to remove the value so there is no ,
on the column, without any values after the ,
?
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @matthewtodd)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Sorry I wasn't clear. That's what this PR does, remove the comma. (The screenshots are of the Before Times.)
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @matthewtodd)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @matthewtodd)
Thanks, @maryliag! bors r+ |
Build succeeded: |
Part of #89949
Previously, when a tenant SQL instance had spun down (leaving us no way to remember which region it had been in), the SQL Activity pages would claim that statements and transactions had occurred in an "undefined" region.
This change moves from saying "undefined" to saying nothing at all, a slightly nicer user experience.
This broader problem of losing the region mapping has been described in #93268; we'll begin addressing it shortly.
Release note: None