Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: increase chaos roachtest latency limits #93552

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

samiskin
Copy link
Contributor

Resolves: #93238

Since our job-level retry MaxBackoff has increased from 10 seconds to 10 minutes, increase the chaos test latency limits.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@samiskin samiskin force-pushed the cdc-increase-sink-chaos-limit branch from 7d04199 to 98d81c4 Compare December 13, 2022 22:01
@samiskin samiskin requested a review from miretskiy December 13, 2022 22:01
steadyLatency: 5 * time.Minute,
// Higher latencies are permitted due to retry backoff
initialScanLatency: 10 * time.Minute,
steadyLatency: 30 * time.Minute,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to figure out how to change that default instead of making tests take longer?

Resolves: cockroachdb#93238

Since our job-level retry MaxBackoff has increased from 10 seconds to 10 minutes, increase the chaos test latency limits.

Release note: None

<what was there before: Previously, ...>
<why it needed to change: This was inadequate because ...>
<what you did about it: To address this, this patch ...>
@samiskin samiskin force-pushed the cdc-increase-sink-chaos-limit branch from 98d81c4 to 4ccf567 Compare December 15, 2022 19:47
@samiskin samiskin requested a review from a team as a code owner December 15, 2022 19:47
Copy link
Contributor

@miretskiy miretskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @samiskin)


pkg/ccl/changefeedccl/retry.go line 33 at r2 (raw file):

			InitialBackoff: 5 * time.Millisecond,
			Multiplier:     2,
			MaxBackoff:     250 * time.Minute,

ouch :)

@samiskin
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 15, 2022

Build succeeded:

@craig craig bot merged commit 2c2822c into cockroachdb:master Dec 15, 2022
@samiskin
Copy link
Contributor Author

blathers backport 22.2

@blathers-crl
Copy link

blathers-crl bot commented Dec 19, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 4ccf567 to blathers/backport-release-22.2-93552: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: cdc/sink-chaos failed
3 participants