-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changefeedccl: increase chaos roachtest latency limits #93552
changefeedccl: increase chaos roachtest latency limits #93552
Conversation
7d04199
to
98d81c4
Compare
pkg/cmd/roachtest/tests/cdc.go
Outdated
steadyLatency: 5 * time.Minute, | ||
// Higher latencies are permitted due to retry backoff | ||
initialScanLatency: 10 * time.Minute, | ||
steadyLatency: 30 * time.Minute, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to figure out how to change that default instead of making tests take longer?
Resolves: cockroachdb#93238 Since our job-level retry MaxBackoff has increased from 10 seconds to 10 minutes, increase the chaos test latency limits. Release note: None <what was there before: Previously, ...> <why it needed to change: This was inadequate because ...> <what you did about it: To address this, this patch ...>
98d81c4
to
4ccf567
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @samiskin)
pkg/ccl/changefeedccl/retry.go
line 33 at r2 (raw file):
InitialBackoff: 5 * time.Millisecond, Multiplier: 2, MaxBackoff: 250 * time.Minute,
ouch :)
bors r+ |
Build succeeded: |
blathers backport 22.2 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 4ccf567 to blathers/backport-release-22.2-93552: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Resolves: #93238
Since our job-level retry MaxBackoff has increased from 10 seconds to 10 minutes, increase the chaos test latency limits.
Release note: None