logictest: ensure lower bound on bytes limit for sqlite #92631
Merged
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrewKimball
reviewed
Nov 29, 2022
pkg/sql/logictest/logic.go
Outdated
| @@ -3999,6 +4000,9 @@ type TestServerArgs struct { | |||
| // If set, then we will disable the metamorphic randomization of | |||
| // smallEngineBlocks variable. | |||
| DisableSmallEngineBlocks bool | |||
| // If set, then default-batch-bytes-limit metamorphic constant is guaranteed | |||
| // to be at least 1KiB. | |||
| EnableLowerBoundOnBatchBytesLimit bool | |||
There was a problem hiding this comment.
[nit] could you make this the lower bound in bytes instead, and just set it to 1KiB here?
There was a problem hiding this comment.
Done. I also decided to bump it up to 3KiB min.
This commit makes it so that `defaultBatchBytesLimit` is set to at least 3KiB when running sqlite logic tests since if that value is too low, the tests can take really long time (in one example with value of 163 bytes it took 25 minutes vs 3 minutes with 2.5KiB value). This is achieved by explicitly updating this single metamorphic value when run with the sqlite target. I chose this option rather than forcing production values knob (which would disable some other randomizations) to have the smallest possible reduction in test coverage while still making the tests fast enough. Release note: None
|
TFTR! bors r+ |
|
LGTM |
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
92463: server, ui: add used index to statement details r=maryliag a=maryliag This commit convert from table id and index id on the statement details endpoint, and adds the index used information to the Explain Plan tab on Statement Details. The elements of the list are links that redirect to the table or index details page. Fixes #82615 https://www.loom.com/share/530bf4e795d648bb854c18d60b074e4c <img width="1483" alt="Screen Shot 2022-11-24 at 11 11 54 AM" src="https://user-images.githubusercontent.com/1017486/203828306-0a6fb905-cae1-4217-8ea3-b4e323cf3a72.png"> Release note (ui change): Add a list of used index per explain plan, under the Explain Plan tab on Statement Details page, with links to the table or index details pages. 92631: logictest: ensure lower bound on bytes limit for sqlite r=yuzefovich a=yuzefovich This commit makes it so that `defaultBatchBytesLimit` is set to at least 3KiB when running sqlite logic tests since if that value is too low, the tests can take really long time (in one example with value of 163 bytes it took 25 minutes vs 3 minutes with 2.5KiB value). This is achieved by explicitly updating this single metamorphic value when run with the sqlite target. I chose this option rather than forcing production values knob (which would disable some other randomizations) to have the smallest possible reduction in test coverage while still making the tests fast enough. Fixes: #92534. Release note: None Co-authored-by: maryliag <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it so that
defaultBatchBytesLimitis set to at least 3KiB when running sqlite logic tests since if that value is too low, the tests can take really long time (in one example with value of 163 bytes it took 25 minutes vs 3 minutes with 2.5KiB value). This is achieved by explicitly updating this single metamorphic value when run with the sqlite target. I chose this option rather than forcing production values knob (which would disable some other randomizations) to have the smallest possible reduction in test coverage while still making the tests fast enough.Fixes: #92534.
Release note: None