Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlstats: add rows_written to node_statement_statistics #92572

Merged
merged 1 commit into from
Nov 29, 2022
Merged

sqlstats: add rows_written to node_statement_statistics #92572

merged 1 commit into from
Nov 29, 2022

Conversation

matthewtodd
Copy link
Contributor

@matthewtodd matthewtodd commented Nov 28, 2022

Fixes #91042

(No release note here since node_statement_statistics is not one of the "Use in production" crdb_internal tables.)

Release note: None

@matthewtodd matthewtodd requested review from a team November 28, 2022 15:10
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @matthewtodd)


-- commits line 6 at r1:
you're adding a new column to a table visible to users, so there should be a release notes here to indicate this, otherwise
:lgtm:

Copy link
Contributor Author

@matthewtodd matthewtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)


-- commits line 6 at r1:

Previously, maryliag (Marylia Gutierrez) wrote…

you're adding a new column to a table visible to users, so there should be a release notes here to indicate this, otherwise
:lgtm:

TFTR! Added a note that node_statement_statistics isn't one of the "Use in production" crdb_internal tables, so we'd previously been instructed to exclude it from release notes.

@matthewtodd
Copy link
Contributor Author

TFTR!

Github CI failure is fixed by #92672

bors r+

@craig craig bot merged commit edc6fda into cockroachdb:master Nov 29, 2022
@craig
Copy link
Contributor

craig bot commented Nov 29, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rowsWritten to 'node_statement_statistics'
3 participants