Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colflow: temporarily disable test assertion about closers #91874

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

yuzefovich
Copy link
Member

Informs: #91845.

Epic: None

Release note: None

@yuzefovich yuzefovich requested review from michae2, DrewKimball and a team November 14, 2022 21:25
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 14, 2022

Build succeeded:

@craig craig bot merged commit a8b0cd9 into cockroachdb:master Nov 14, 2022
@yuzefovich yuzefovich deleted the closers-no-assertions branch November 14, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants