sql: use schema desc ID for OIDs in vtables #90793
Conversation
|
This change is |
There was a problem hiding this comment.
I guess this just works, doesn't it? That's great. At first I was thinking it was bad that the virtual schemas in different databases have the same OID, but OIDs are database-scoped in pg_catalog, so it's fine, right?
Will this mean we can more or less trivially add an index on pg_namespace?
Reviewed all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained
that was my thought as well. it should just work!
yeah. my motivation was to fix the perf problem i ran into in #90649 |
rafiss
force-pushed
the
schema-oids
branch
4 times, most recently
from
81172fe to
f774b89
Compare
The OIDs for schemas in the information_schema and pg_catalog tables are all now the same as the descriptor ID. For virtual schemas, the IDs are hardcoded. No release note since OIDs are not really meant to be used externally, and we've changed these in the past without fanfare. Release note: None
|
bors r=ajwerner |
|
bors r+ |
|
Already running a review |
|
Build failed (retrying...): |
|
Build succeeded: |
The OIDs for schemas in the information_schema and pg_catalog tables are all now the same as the descriptor ID. For virtual schemas, the IDs are hardcoded.
No release note since OIDs are not really meant to be used externally, and we've changed these in the past without fanfare.
Release note: None
Epic: None