bazel,ci: check generated code and docs are up-to-date in CI #89516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I created the file `build/bazelutil/checked_in_genfiles.txt` it was meant to contain an exhaustive list of all checked-in Go code, to be used by CI. In reality this file never had an exhaustive list and is not updated when new checked-in generated files are added. These days we have the `pkg/gen` infrastructure which *does* keep an exhaustive list of checked-in generated code, so the file is redundant anyway. Here I delete the file and just directly run `pkg/gen` for checking whether the generated code is up-to-date. Closes cockroachdb#88744. Release note: None
|
This change is |
|
bors r=rail |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I created the file
build/bazelutil/checked_in_genfiles.txtit was meant to contain an exhaustive list of all checked-in Go code, to be used by CI. In reality this file never had an exhaustive list and is not updated when new checked-in generated files are added. These days we have thepkg/geninfrastructure which does keep an exhaustive list of checked-in generated code, so the file is redundant anyway. Here I delete the file and just directly runpkg/genfor checking whether the generated code is up-to-date.Closes #88744.
Release note: None