sql: add eventlog for UDF relevant statements #88304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
chengxiong-ruan
commented
Sep 20, 2022
pkg/sql/alter_function.go
Outdated
| } | ||
| event := eventpb.AlterFunctionOptions{ | ||
| FunctionName: fnName.FQString(), | ||
| Options: fctx.CloseAndGetString(), |
There was a problem hiding this comment.
adding alter function details here is probably a overkill....
There was a problem hiding this comment.
the event log json records the whole statement, so no need to book keeping redundant option details
chengxiong-ruan
force-pushed
the
udf-log-event-for-udf-statements
branch
from
82bff78 to
f62b44b
Compare
|
Why are there no tests? |
oops, my bad, adding it now |
chengxiong-ruan
force-pushed
the
udf-log-event-for-udf-statements
branch
2 times, most recently
from
67b7741 to
355373b
Compare
|
@postamar logic tests added |
chengxiong-ruan
force-pushed
the
udf-log-event-for-udf-statements
branch
from
355373b to
791b2c0
Compare
postamar
approved these changes
Sep 21, 2022
|
shipping it anyway. don't think it'd be a big deal as long as the event type are clear, desc id and ddl statement are well recorded. |
|
Build failed: |
Backport addresses cockroachdb#86058. Release note: None Release justification: low risk GA blocker
chengxiong-ruan
force-pushed
the
udf-log-event-for-udf-statements
branch
from
791b2c0 to
9f36dad
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport addresses #86058.
Release note: None
Release justification: low risk GA blocker