ccl/backupccl: add application name to backup/restore telemetry #87875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
approved these changes
Sep 13, 2022
Add application name as a field in RecoveryEvent. Record the session application name for every invoked backup, restore, and backup schedule creation. Release note: None
|
Is it? We went to great lengths to scrub the app name in sql stats (we added cluster.secret and a migration to populate it with a random nonce all so that we could hash that into the app name to make it irreversible in telemetry) |
|
I assumed so after looking for this PR that changed the sensitivity to |
|
Ah, I guess @dhartunian and SQL people concluded it isn't sensitive. Carry on then. |
|
bors r+ |
|
Build failed: |
|
bors retry |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add application name as a field in RecoveryEvent. Record the session application name for every invoked backup, restore, and backup schedule creation.