release-22.1: admin: tenant support jobs endpoints #87432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dhartunian
changed the title
maryliag
approved these changes
Sep 7, 2022
complete! 1 of 0 LGTMs obtained
Release note: None Release justification: non-production code change
dhartunian
force-pushed
the
backport22.1-84620
branch
from
a96ac2c to
6713f55
Compare
Previously, the Job() and Jobs() endpoints were not implemented on the tenant admin server as there was not a need and we had split the implementation into a tenant-only server. Now that we want to ship the jobs page into CC Console and support it for multi-tenant, the endpoints for the UI should work as expected. This PR edits the `jobHelper` and `jobsHelper` helpers to be functions instead of methods in `adminServer` which allows the implementation to be shared between the two servers. Release note: None Release justification: low risk, high benefit addition to multi-tenant
dhartunian
force-pushed
the
backport22.1-84620
branch
from
6713f55 to
f2da108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None
Release justification: non-production code changeBackport 2/2 commits from #84620.
/cc @cockroachdb/release
Previously, the Job() and Jobs() endpoints were not implemented on the
tenant admin server as there was not a need and we had split the
implementation into a tenant-only server.
Now that we want to ship the jobs page into CC Console and support it
for multi-tenant, the endpoints for the UI should work as expected.
This PR edits the
jobHelperandjobsHelperhelpers to be functionsinstead of methods in
adminServerwhich allows the implementation tobe shared between the two servers.
Fixes #84621.
Release note: None
Release justification: low risk, high benefit addition to multi-tenant