roachpb: remove deprecated error fields #86683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
remove-deprecated-roachpb-error-fields
branch
from
3666d87 to
9793763
Compare
tbg
approved these changes
Aug 24, 2022
|
There's something not quite right here. I'm off until next Tuesday. If anybody finds time to do something about it between now and then, that'd be great. |
|
Seeing this only now, let me see if I can figure it out in the hour I have left today. |
tbg
reviewed
Aug 29, 2022
tbg
force-pushed
the
remove-deprecated-roachpb-error-fields
branch
from
9793763 to
c2b9142
Compare
|
Going to leave this sit now, the branch cut was delayed by a day so hopefully this will turn green and we can hit the button later today or early tmrw. |
|
CI is behaving oddly, see slack |
|
@ajwerner going to hand this back to you if that's ok. I think this PR should be green but somehow it isn't. Stuff passes locally. Hopefully the slack thread will produce something illuminating. |
ajwerner
force-pushed
the
remove-deprecated-roachpb-error-fields
branch
from
f1cc354 to
f9dd5b1
Compare
ajwerner
force-pushed
the
remove-deprecated-roachpb-error-fields
branch
from
f9dd5b1 to
0d5e704
Compare
It turns out these unexported fields can cause pain. As far as I can tell, these deprecated fields haven't been needed for a whole release. I'll note that we probably ought to more generally fix gogoproto to not try to marshal unexported fields and we should probably disallow them, but, alas, this is the most expedient thing for me to do here. Fixes cockroachdb#86664 Fixes cockroachdb#86509 Release justification: Important bug fix. Release note: None
ajwerner
force-pushed
the
remove-deprecated-roachpb-error-fields
branch
from
0d5e704 to
0c12f6c
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out these unexported fields can cause pain. As far as I can tell,
these deprecated fields haven't been needed for a whole release. I'll note
that we probably ought to more generally fix gogoproto to not try to marshal
unexported fields and we should probably disallow them, but, alas, this is
the most expedient thing for me to do here.
Fixes #86664
Fixes #86509
Release justification: Important bug fix.
Release note: None