sql/schemachanger: fixed a ordial number bug in ALTER PRIMARY KEY #86192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we had a bug in ALTER PRIMARY KEY such that when the new primary key is a superset of the old primary key, we incorrectly gave ordinal numbers to IndexColumn elements. This PR fixed it and added a few logic tests for cases when the new primary key intersects with the old primary key. Fixes: cockroachdb#85877 Release note: None Release justification: fixed a bug that was revealed in roachtest failure (issue cockroachdb#85877)
|
This change is |
ajwerner
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
This feels like the sort of bug that randomized testing would catch quickly. We should add support for ALTER PRIMARY KEY to that thing. I filed #86199.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Xiang-Gu)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had a bug in ALTER PRIMARY KEY such that when the new
primary key is a superset of the old primary key, we incorrectly gave
ordinal numbers to IndexColumn elements. This PR fixed it and added
a few logic tests for cases when the new primary key intersects with
the old primary key.
Fixes: #85877
Release note: None
Release justification: fixed a bug that was revealed in roachtest
failure (issue #85877)