colexecbase: add all casts of native types to strings #85681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
changed the title
This is not used currently but will be in the following commit. Release note: None
This commit adds all of the casts from the types natively supported by the vectorized engine to strings. This has an additional benefit (apart from better performance on a lot of data: the concat binary projection with a string on one side is now supported natively (we recently fixed an issue to plan a cast of a non-string type to a string for a concat operation, but since we didn't have the cast support, we'd be falling back to the row-by-row engine in most cases). Release note: None
msirek
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
This is great! I'm wondering if there are any more missing casts in the vectorized engine. Should we open an issue to track researching this?
Reviewed 5 of 5 files at r1, 11 of 11 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
Yeah, #48135 tracks that (and this PR won't close that issue). It doesn't seem worth it to explicitly spell out casts that are still missing in that issue - it seems sufficient just to look at the top of TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colexecbase: propagate bytes.Buffer as argument in cast templates
This is not used currently but will be in the following commit.
Release note: None
colexecbase: add all casts of native types to strings
This commit adds all of the casts from the types natively supported by
the vectorized engine to strings. This has an additional benefit (apart
from better performance on a lot of data: the concat binary projection
with a string on one side is now supported natively (we recently fixed
an issue to plan a cast of a non-string type to a string for a concat
operation, but since we didn't have the cast support, we'd be falling
back to the row-by-row engine in most cases).
Addresses: #48135.
Fixes: #49463.
Fixes: #55841.
Release note: None