roachpb: remove RangeDescriptor.deprecated_generation_comparable
#85118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This patch removes the unused field `deprecated_generation_comparable` from `RangeDescriptor`. The preparatory work for this was done in 20.2, see a578719. Release note: None
erikgrinaker
force-pushed
the
remove-deprecated-generation-comparable
branch
from
d2d66e1 to
4990c09
Compare
pav-kv
reviewed
Jul 27, 2022
andreimatei
reviewed
Jul 27, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker and @pavelkalinnikov)
pkg/roachpb/metadata.proto line 285 at r1 (raw file):
Previously, erikgrinaker (Erik Grinaker) wrote…
Nah, all of our
reserveddeclarations use IDs only.
The field name can be reused. We don't store these protos as JSON or anything like that.
|
TFTRs! bors r=pavelkalinnikov,andreimatei |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the unused field
deprecated_generation_comparablefrom
RangeDescriptor. The preparatory work for this was done in 20.2,see a578719.
Release note: None