bulk: replace old SSTIterators with PebbleSSTIterator in bulk stack #85068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
force-pushed
the
butler-replace-ssts
branch
from
bfb4816 to
69cb410
Compare
This is purely a refactor. The only prod refactor is in the SSTBatcher, where it calls ComputeStatsForRange. This should not have a significant perf hit as the iterator only surfaces point keys and the bulk of sst_batcher comput time is spent in doing ingestion. Currently the pebbleIterator is slightly slower than the old iterator, but optimizations are coming soon (cockroachdb#83051). Release note: none
msbutler
force-pushed
the
butler-replace-ssts
branch
from
69cb410 to
d411861
Compare
|
friendly ping! |
erikgrinaker
approved these changes
Jul 28, 2022
|
TFTR!! bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is purely a refactor. The only prod refactor is in the SSTBatcher, where
it calls ComputeStatsForRange. This should not have a significant perf hit
as the iterator only surfaces point keys and the bulk of sst_batcher comput
time is spent in doing ingestion. Currently the pebbleIterator is
slightly slower than the old iterator, but optimizations are coming soon
(#83051).
Release note: none