Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: rename OptGen.tmbundle to OptGen #85035

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

mgartner
Copy link
Collaborator

This is a temporary workaround for a bug in GoLand that prevents
installing and using the OptGen TextMate bundle:

https://youtrack.jetbrains.com/issue/GO-13411/Cannot-install-TextMate-bundles-with-tmbundle-suffix

I plan to revert this change once the bug in GoLand has been fix.

Release note: None

This is a temporary workaround for a bug in GoLand that prevents
installing and using the OptGen TextMate bundle:

https://youtrack.jetbrains.com/issue/GO-13411/Cannot-install-TextMate-bundles-with-tmbundle-suffix

I plan to revert this change once the bug in GoLand has been fix.

Release note: None
@mgartner mgartner requested a review from a team as a code owner July 25, 2022 22:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner requested review from michae2 and yuzefovich July 25, 2022 22:09
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @michae2)

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @mgartner)

@mgartner
Copy link
Collaborator Author

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 26, 2022

Build succeeded:

@craig craig bot merged commit a5ccdc3 into cockroachdb:master Jul 26, 2022
@mgartner mgartner deleted the optgen-bundle-workaround branch July 26, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants