sql/sem/builtins: move definitions map to new package #84360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, the definition of builtin functions live in the `builtins` package. This was undesirable because various other packages need to acceess builtins properties by name, but it has a been a headache to achieve this without importing the `builtins` package, which stands pretty high in the dependecy chain (e.g. `seqexpr`, `memo`). This PR moves builtins definition into a new registry package that the `builtins` package calls to register builtin functions, which happens in the `init()` function. This way, other lower level packages, who wish to access builtins properties, need only to import the newly created `builtinsregistry` package. Release note: None
Xiang-Gu
force-pushed
the
ajwerner/builtin-registry
branch
from
6b3dd3f to
cee2f34
Compare
|
@chengxiong-ruan can you take a look at this. It's a little bit gross in that |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the definition of builtin functions live in the
builtinspackage. This was undesirable because various other packages need to
acceess builtins properties by name, but it has a been a headache to
achieve this without importing the
builtinspackage, which standspretty high in the dependecy chain (e.g.
seqexpr,memo).This PR moves builtins definition into a new registry package that the
builtinspackage calls to register builtin functions, which happensin the
init()function. This way, other lower level packages, whowish to access builtins properties, need only to import the newly
created
builtinsregistrypackage.Release note: None