tracing: delete old field #84323
Merged
tracing: delete old field #84323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dhartunian
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
pkg/server/node_tenant.go line 25 at r1 (raw file):
// redactRecordingForTenant redacts the sensitive parts of log messages in the // recording if the tenant to which this recording is intended is not the system // tenant (the system tenant gets an. See https://github.com/cockroachdb/cockroach/issues/70407.
nit: something happened here...
The RecordedSpan.RedactableLogs. This field was unused since 22.1. Release note: None
andreimatei
commented
Jul 20, 2022
There was a problem hiding this comment.
Reviewable status:
pkg/server/node_tenant.go line 25 at r1 (raw file):
Previously, dhartunian (David Hartunian) wrote…
nit: something happened here...
I think something had happened in the past and now I fixed it. No?
andreimatei
force-pushed
the
small.tracing.RedactableLogs
branch
from
600ab70 to
221ac55
Compare
andreimatei
commented
Jul 21, 2022
There was a problem hiding this comment.
bors r+
Reviewable status:
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RecordedSpan.RedactableLogs. This field was unused since 22.1.
Release note: None