bazel: in check.sh, restrict grep to pkg
#83866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
matthewtodd
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Thanks, @rickystewart! On your suspicion that it was something about the git version, I checked my config, and indeed I had set submodule.recurse for visibility into changes in my vim plugins. Oops. Seems like restricting this grep is still a good idea.
You can optionally configure `git grep` to recurse into submodules, in which case this check returns false positives. Here we restrict the search to the `pkg` directory which is all we care about. Release note: None
rickystewart
force-pushed
the
checkgogenerate
branch
from
62f5074 to
8a6bedb
Compare
|
bors r=matthewtodd |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
bors r=matthewtodd |
|
Build succeeded: |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can optionally configure
git grepto recurse into submodules, inwhich case this check returns false positives. Here we restrict the
search to the
pkgdirectory which is all we care about.Release note: None