storage: add nextKeyIgnoringTime() to MVCCIncrementalIterator #83729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
force-pushed
the
butler-nextkeyignoringtime
branch
from
0b69f89 to
3d4600d
Compare
msbutler
commented
Jul 6, 2022
stevendanna
reviewed
Jul 6, 2022
erikgrinaker
reviewed
Jul 7, 2022
msbutler
force-pushed
the
butler-nextkeyignoringtime
branch
from
24003fa to
6a93f0c
Compare
msbutler
changed the title
The MVCCInvermentalIterator's NextKeyIgnoringTime() function was previously deleted in cockroachdb#82691, as there wasn't any use for it at the time. Now, the new Delete Range with predicate filtering will need it (cockroachdb#83676). This PR also cleans up duplicate code used to test NextIgnoringTime and NextKeyIgnoringTime. Release note: None
msbutler
force-pushed
the
butler-nextkeyignoringtime
branch
from
6a93f0c to
8c9df8a
Compare
|
TFTR!! bors r=erikgrinaker |
|
Build failed (retrying...): |
|
Build succeeded: |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MVCCInvermentalIterator's NextKeyIgnoringTime() function was previously
deleted in #82691, as there wasn't any use for it at the time. Now, the new
Delete Range with predicate filtering will need it (#83676).
This PR also cleans up duplicate code used to test NextIgnoringTime and
NextKeyIgnoringTime.
Release note: None