sql: added inet function to support conversion to inet type

[surahman]

Release note (sql change):
The inet function has been added to support the conversion of a supplied type to that of the inet
type family. If the conversion fails a SQL error will be output.

Closes #82052.

[blathers-crl]

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[cockroach-teamcity]

This change is 

[surahman]

• I am doubtful of whether the SQL parser needs to be updated to handle this or if there is some automated generation process. Some of the builtins do not provide any additions to the SQL parser.
• The function currently returns an error if the conversion fails. I was unable to find the documentation for the inet function in PostreSQL. MySQL handles a failed conversion by returning a NULL. How should this case be handled?
• I have selected the input as type.Any. The issue did not specify a specific conversion type (sample contains string) so I went the route of trying to convert whatever type is provided. How should input type be defined?
• The user documentation in docs/generated/sql also needs to be autogenerated.

[blathers-crl]

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[blathers-crl]

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

• We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
• When CI has completed, please ensure no errors have appeared.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[surahman]

Not sure about the benchmark failures there are no details in the CI logs. I think they might be spurious. Everything passes locally. This is failing on exactly the same tests which were run in the same time window.

[rafiss]

thank you for your contribution!

i left a few small comments, but this looks good

you will need to run ./dev generate docs or make buildshort to make sure the generated docs are up to date

please address the comments, and amend your original commit with the changes. thanks!

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @surahman)

---

-- commits line 5 at r1:
nit: please add newlines to the message so it's at most 100 characters wide

---

pkg/sql/sem/builtins/builtins.go line 1051 at r1 (raw file):

	"inet": makeBuiltin(defProps(),
		tree.Overload{
			Types:      tree.ArgTypes{{"val", types.Any}},

to match postgres, we should make this only accept types.String. (PG actually accepts type cstring here, but CRDB doesn't have that)

---

pkg/sql/sem/builtins/builtins.go line 1057 at r1 (raw file):

				if err != nil {
					return nil, pgerror.Newf(
						pgcode.InvalidParameterValue, "could not convert to INet: %s", args[0])

to match postgres, let's use pgcode.InvalidTextRepresentation

also, instead of pgerror.Newf, please use the original error

return nil, pgerror.WithCandidateCode(err, pgcode.InvalidTextRepresentation)

---

pkg/sql/sem/builtins/builtins.go line 1061 at r1 (raw file):

				return inet, nil
			},
			Info:       "If possible, converts input to that of type INet.",

please use "inet" instead of "INet"

[surahman]

Thank you @rafiss

[surahman]

Bazel CI failure appears to be unrelated.

[17:02:04][Run unit tests] === RUN   TestTenantLogic/3node-tenant/grant_on_all_sequences_in_schema
[17:02:04][Run unit tests] [17:02:02] setting distsql_workmem='34458B';
[17:02:04][Run unit tests] [17:02:02] setting distsql_workmem='34458B';
[17:02:04][Run unit tests] [17:02:03] rng seed: 1456840546540403413
[17:02:04][Run unit tests] 
[17:02:04][Run unit tests] -- Test timed out at 2022-07-15 17:02:03 UTC --

grant_on_all_sequences_in_schema

[rafiss]

thanks for your work! this looks good to me

bors r+

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @surahman)

[surahman]

Thank you @rafiss

[craig]

Build succeeded:

• GitHub CI (Cockroach)