ui: add internal app filter to active statements and transactions pages #83014
Conversation
|
This change is |
|
I will probably want to update this PR to handle |
There was a problem hiding this comment.
Awesome!
Agree with updating the usage on unset here.
Also, can you confirm if you select both app names on the filter it will show values for both? I think that was the only test missing from the video (no need to record another video, just want to make sure you tested that case too)
Otherwise,
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)
ericharmeling
force-pushed
the
internal-stmt-txn-filters
branch
from
97251c6 to
09dcb32
Compare
Confirmed! Screen.Recording.2022-06-28.at.11.06.36.AM.mov |
ericharmeling
force-pushed
the
internal-stmt-txn-filters
branch
10 times, most recently
from
33c3781 to
b955f18
Compare
ericharmeling
force-pushed
the
internal-stmt-txn-filters
branch
from
b955f18 to
7b6eeee
Compare
This commit adds a single internal app filter option on to the Active Statements and Active Transactions pages. Active statements and transactions run by internal apps are no longer displayed by default. Release note (ui change): The Active Statements and Active Transactions pages now have a single filter option for internal apps. These pages no longer display internal statements and transactions by default.
ericharmeling
force-pushed
the
internal-stmt-txn-filters
branch
from
7b6eeee to
c9f8474
Compare
|
The Bazel check failures appear to be unrelated to the changes in this PR |
|
bors r+ |
|
Build succeeded: |
This PR adds a single internal app filter option on to the Active Statements and Active Transactions pages. Active
statements and transactions run by internal apps are no longer displayed by default.
See commit message for release note.
Screen.Recording.2022-06-16.at.4.08.00.PM.mov
Fixes #81072.