workload/schemachanger: allow unknown schema errors in certain contexts #82941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
I wish that once we read descriptors for the virtual tables we used those for all purposes in the transaction and if we read them after leasing a descriptor, we sent a retry error if there was a version mismatch. That's #64673 -- can you reference that issue here?
Reviewable status:
complete! 0 of 0 LGTMs obtained
Previously, the schema changer workload could hit intermittent errors when descriptors were bound after being looked up using crdb_internal table. Unfortunately, the crdb_internal tables never lease out descriptors, so these schema could be pulled from under us. To address this, this patch will allow unknown schema errors for certain crdb_internal queries that are likely to observe this condition. Addressing issue cockroachdb#64673 would improve some of this behavior, and eliminate the need for the workaround here, since we would automatically get a retry error. Release note: None
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the schema changer workload could hit intermittent
errors when descriptors were bound after being looked up using
crdb_internal table. Unfortunately, the crdb_internal tables never
lease out descriptors, so these schema could be pulled from under us.
To address this, this patch will allow unknown schema errors for
certain crdb_internal queries that are likely to observe this
condition.
Addressing issue #64673 would improve some of this behaviour,
and eliminate the need for the workaround here, since we would
automatically get a retry error.
Release note: None