Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add evalgen instructions #82351

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented Jun 2, 2022

This commit adds some comments that explain how to generate code with
evalgen.

Release note: None

@mgartner mgartner requested a review from ajwerner June 2, 2022 14:10
@mgartner mgartner requested a review from a team as a code owner June 2, 2022 14:10
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner
Copy link
Collaborator Author

mgartner commented Jun 7, 2022

Friendly ping @ajwerner.

@mgartner
Copy link
Collaborator Author

@ajwerner friendly ping :)

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

@mgartner
Copy link
Collaborator Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 22, 2022

Build failed (retrying...):

This commit adds some comments that explain how to generate code with
`evalgen`.

Release note: None
@mgartner mgartner force-pushed the evalgen-instructions branch from 6b679c0 to c10ce41 Compare June 22, 2022 19:56
@craig
Copy link
Contributor

craig bot commented Jun 22, 2022

Canceled.

@mgartner
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 23, 2022

Build succeeded:

@craig craig bot merged commit 1140872 into cockroachdb:master Jun 23, 2022
@mgartner mgartner deleted the evalgen-instructions branch June 23, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants