kv: don't consider skipped snapshots to be "processed" by queues #81767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a support issue, we saw a very high rate of successful raftsnapshot queue process attempts. This was confusing, as the rate of snapshots sent was much lower. It turns out that this was because most snapshots were being skipped on the "replica is likely in the process of being added" path. To avoid this confusion in the future, we no longer return `true` as the value for `processed` from `raftSnapshotQueue.process` method in these cases.
|
This change is |
kvoli
approved these changes
May 24, 2022
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a support issue, we saw a very high rate of successful raftsnapshot
queue process attempts. This was confusing, as the rate of snapshots
sent was much lower. It turns out that this was because most snapshots
were being skipped on the "replica is likely in the process of being
added" path.
To avoid this confusion in the future, we no longer return
trueas thevalue for
processedfromraftSnapshotQueue.processmethod in thesecases.