Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admission: avoid spurious logging when not in IO overload #81661

Merged
merged 1 commit into from
May 23, 2022

Conversation

tbg
Copy link
Member

@tbg tbg commented May 23, 2022

I broke this in #80859.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg requested a review from sumeerbhola May 23, 2022 13:04
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @tbg)

@tbg tbg force-pushed the granter-dolog branch from 2354f8d to 50649b6 Compare May 23, 2022 13:51
@tbg tbg marked this pull request as ready for review May 23, 2022 13:53
@tbg
Copy link
Member Author

tbg commented May 23, 2022

bors r=sumeerbhola
TFTR!

@craig
Copy link
Contributor

craig bot commented May 23, 2022

Build failed:

@tbg
Copy link
Member Author

tbg commented May 23, 2022

TestLogic/fakedist-disk/distsql_event_log

bors r=sumeerbhola

@craig
Copy link
Contributor

craig bot commented May 23, 2022

Build succeeded:

@craig craig bot merged commit 8678422 into cockroachdb:master May 23, 2022
@tbg tbg deleted the granter-dolog branch May 23, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants