storage: make key/value printing explicitly redactable #81495
Conversation
|
This change is |
There was a problem hiding this comment.
Thanks. Where are the unit tests?
Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @nerdroychan)
There was a problem hiding this comment.
Looks great, would be easy to add a test in mvcc_test.go that basically does
func TestFormatKeyAndValues(t *testing.T) {
// ..usual test setup..
// Test that values and keys are printed with redaction markets.
require.Equal(t, FormatBytesAsKey([]byte("foo")), "‹foo›")
require.Equal(t, FormatBytesAsValue([]byte("foo")), "‹foo›")
}
Reviewed all commit messages.
Reviewable status:
There was a problem hiding this comment.
Thanks. The unit tests are added to mvcc_test.go.
Reviewable status:
This commit makes the formatting functions in storage/enginepb return explicitly redactable strings. Resolve #70288. Release note: None
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
|
bors r=itsbilal,knz |
|
Build failed (retrying...): |
|
Build succeeded: |
This commit makes the formatting functions in storage/enginepb
return explicitly redactable strings.
Resolve #70288.
Release note: None