ccl/sqlproxyccl: add metrics to track the number of rebalance requests #79874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jaylim-crl
requested review from
jeffswenson and
andy-kimball
and removed request for
a team
jaylim-crl
force-pushed
the
jay/220412-add-balancer-metrics
branch
from
9e3fa7a to
21043df
Compare
This commit addresses a TODO by adding metrics to track the number of rebalance requests (total, queued, and running). The following metrics are added: - proxy.balancer.rebalance.running - proxy.balancer.rebalance.queued - proxy.balancer.rebalance.total Release note: None
jaylim-crl
force-pushed
the
jay/220412-add-balancer-metrics
branch
from
21043df to
cb73631
Compare
jaylim-crl
commented
Apr 13, 2022
There was a problem hiding this comment.
TFTR!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andy-kimball)
pkg/ccl/sqlproxyccl/balancer/metrics.go, line 48 at r1 (raw file):
Previously, JeffSwenson (Jeff Swenson) wrote…
nit: (really nitty) name this NewMetrics() instead of MakeMetrics(). New is the most common prefix in go for factory functions.
Done. Thanks. Also, I believe CRDB has a convention of using NewX for something that returns a pointer, and MakeX for regular objects.
|
TFTR! bors r=JeffSwenson |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a TODO by adding metrics to track the number of rebalance
requests (total, queued, and running). The following metrics are added:
Release note: None