colexecproj: break it down into two packages

[yuzefovich]

colexecproj: split up default cmp proj op file into two

This commit splits up a single file containing two default comparison
projection operators into two files. This is done in preparation of
the following commit (which will move one of the operators to a
different package).

Release note: None

colexecproj: extract a new package for projection ops with const

This commit extracts a new colexecprojconst package out of
colexecproj that contains all projection operators with one
constant argument. This will allow for faster build speeds since both
packages tens of thousands lines of code.

Special care had to be taken for default comparison operator because we
need to generate two files in different packages based on a single
template. I followed the precedent of sort_partitioner.eg.go which had
to do the same.

Addresses: #79357.

Release note: None

[cockroach-teamcity]

This change is 

[michae2]

Just a couple bazel questions, but this looks good.

Reviewed 7 of 7 files at r1, 32 of 32 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @irfansharif, @rickystewart, and @yuzefovich)

---

pkg/sql/colexec/COLEXEC.bzl, line 26 at r2 (raw file):

        cmd = """\
export COCKROACH_INTERNAL_DISABLE_METAMORPHIC_TESTING=true
$(location :execgen) -template $(SRCS) -fmt=false pkg/sql/colexec/colexecprojconst$@ > $@

Should this have a / after colexecprojconst?

---

pkg/sql/colexec/colexecprojconst/BUILD.bazel, line 24 at r2 (raw file):

        "//pkg/sql/colexec/colexecbase",  # keep
        "//pkg/sql/colexec/colexeccmp",
        "//pkg/sql/colexec/colexecutils",

In colexecproj/BUILD.bazel all deps now have # keep. Should they all have it here as well?

---

pkg/sql/colexec/execgen/cmd/execgen/default_cmp_proj_ops_gen.go, line 35 at r1 (raw file):

// licenses/APL.txt.

package %s

nit: Since this is a template, I think you could use {{.TargetPkg}} instead of %s if you wanted to avoid the call to fmt.Sprintf. (Then you'd need to add TargetPkg to defaultCmpProjOpOverload.)

[yuzefovich]

TFTR!

bors r+

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @irfansharif, @michae2, and @rickystewart)

---

pkg/sql/colexec/COLEXEC.bzl, line 26 at r2 (raw file):

Previously, michae2 (Michael Erickson) wrote…

Should this have a / after colexecprojconst?

Nice catch! I don't know if it matters (because the bazel build still works), but it's good to be consistent with the above, fixed.

---

pkg/sql/colexec/colexecprojconst/BUILD.bazel, line 24 at r2 (raw file):

Previously, michae2 (Michael Erickson) wrote…

In colexecproj/BUILD.bazel all deps now have # keep. Should they all have it here as well?

# keep is a special directive to make sure that bazel doesn't prune dependencies that are needed only by the generated code. In other words, if we can get by without using # keep (meaning that there is regular, non-generated code that needs a particular dependency), then it's preferable, but in colexecproj we no longer have such code, so we have to use # keep directive.

---

pkg/sql/colexec/execgen/cmd/execgen/default_cmp_proj_ops_gen.go, line 35 at r1 (raw file):

Previously, michae2 (Michael Erickson) wrote…

nit: Since this is a template, I think you could use {{.TargetPkg}} instead of %s if you wanted to avoid the call to fmt.Sprintf. (Then you'd need to add TargetPkg to defaultCmpProjOpOverload.)

Nice, I like this, done.

[craig]

Build succeeded:

• GitHub CI (Cockroach)