storage: only call Desc() if needed in queues #7888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It requires getting a lock, so we should avoid calling it unnecessarily.
|
It might not be a bad idea to spend some time looking for all calls that require a lock and see if any other calls around it acquire the same look right after, or if they're actually required. Desc() I'll bet is going to be one of the biggest culprits. |
|
Take a look at the refactor of Comments from Reviewable |
|
As discussed, I like that idea. But as far this change is concerned, there's an early exit condition that seems to make sense to move it up. Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
rjnn
pushed a commit
to rjnn/cockroach
that referenced
this pull request
Jul 18, 2016
In cockroachdb#7871, replica.String() was refactored to use a new atomically readable copy of the RangeDescriptor. replica.Desc() could use this as well (so as to not lock replica.mu), but this change was conservatively deferred. However, with the issue of replica.Desc() acquiring locks being raised in cockroachdb#7888, and after discussion with @bdarnell, it should be safe to refactor replica.Desc() as well. Finally replica.mu.rangeDesc is moved outside mu to replica.rangeDesc to maintain the semantics of replica.mu
rjnn
pushed a commit
to rjnn/cockroach
that referenced
this pull request
Jul 19, 2016
In cockroachdb#7871, replica.String() was refactored to use a new atomically readable copy of the RangeDescriptor. replica.Desc() could use this as well (so as to not lock replica.mu), but this change was conservatively deferred. However, with the issue of replica.Desc() acquiring locks being raised in cockroachdb#7888, and after discussion with @bdarnell, it should be safe to refactor replica.Desc() as well. Finally replica.mu.rangeDesc is moved outside mu to replica.rangeDesc to maintain the semantics of replica.mu
rjnn
pushed a commit
to rjnn/cockroach
that referenced
this pull request
Jul 19, 2016
In cockroachdb#7871, replica.String() was refactored to use a new atomically readable copy of the RangeDescriptor. replica.Desc() could use this as well (so as to not lock replica.mu), but this change was conservatively deferred. However, with the issue of replica.Desc() acquiring locks being raised in cockroachdb#7888, and after discussion with @bdarnell, it should be safe to refactor replica.Desc() as well. Finally replica.mu.rangeDesc is moved outside mu to replica.rangeDesc to maintain the semantics of replica.mu
rjnn
pushed a commit
that referenced
this pull request
Jul 20, 2016
storage: prepend replica descriptors in panics all logs and errors with it. Prepend panics as well. storage: move rangeDesc out of replica.mu, use in Desc() readable copy of the RangeDescriptor. replica.Desc() could use this as well (so as to not lock replica.mu), but this change was conservatively deferred. However, with the issue of replica.Desc() acquiring locks being raised in #7888, and after discussion with @bdarnell, it should be safe to refactor replica.Desc() as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires getting a lock, so we should avoid calling it unnecessarily.
This change is