types: remove no longer used version gate #77320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the definition of `BytesEncodeFormat` enum from `sessiondatapb` to `lex`. This is done in order to make `lex` not depend on a lot of stuff (eventually on `roachpb`) and is a part of the effort to clean up the dependencies of `execgen`. Note that the proto package name is not changed, so this change is backwards-compatible. Release note: None Release justification: low risk change to clean up the dependencies.
This is done in preparation of breaking the dependency of `sql/types` on `roachpb` (which is a part of the effort to clean up the dependencies of `execgen`). Although there is an ask in place to not remove this code even if it's not used at the moment (so that we have the necessary infra in place if/when the need arises), in order to keep the functionality we would need to pull out `roachpb.Version` out of `roachpb`, and I don't want to embark on that since we're in stability period. Release note: None Release justification: low risk change to clean up the dependencies.
|
This change is |
|
Note that the first commit is in a separate PR and should be ignored here. |
|
Actually, looks like this is the last piece, so I'll continue this in #77260. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #77319.
This is done in preparation of breaking the dependency of
sql/typesonroachpb(which is a part of the effort to clean up the dependencies ofexecgen). Although there is an ask in place to not remove this codeeven if it's not used at the moment (so that we have the necessary infra
in place if/when the need arises), in order to keep the functionality we
would need to pull out
roachpb.Versionout ofroachpb, and I don'twant to embark on that since we're in stability period.
Addresses: #77234.
Release note: None
Release justification: low risk change to clean up the dependencies.