Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: include tenant_settings in cluster backup #76758

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

RaduBerinde
Copy link
Member

We include the tenant_settings table in full cluster backups. This
means that when we restore a cluster, all overrides should be in
place.

The overrides are treated as a host cluster property. When restoring
only specific tenants, the overrides will not be carried over.

In the future, we can add tenant-specific overrides to tenant metadata
so restoring a single tenant restores the overrides as well.

Release note: None

@RaduBerinde RaduBerinde requested review from dt and a team February 17, 2022 21:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

We include the tenant_settings table in full cluster backups. This
means that when we restore a cluster, all overrides should be in
place.

The overrides are treated as a host cluster property. When restoring
only specific tenants, the overrides will not be carried over.

In the future, we can add tenant-specific overrides to tenant metadata
so restoring a single tenant restores the overrides as well.

Release note: None
@RaduBerinde RaduBerinde force-pushed the tenant-settings-backup-2 branch from c698608 to 0ec2bcd Compare February 17, 2022 22:15
@RaduBerinde
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 18, 2022

Build succeeded:

@craig craig bot merged commit ff2396b into cockroachdb:master Feb 18, 2022
@RaduBerinde RaduBerinde deleted the tenant-settings-backup-2 branch February 19, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants