Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/tracing: improve a comment #76317

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Conversation

andreimatei
Copy link
Contributor

Hint that there's no race between dropping a span's lock when it's in
the middle of finishing and the parent inserting that span into the
registry.

Release note: None

Hint that there's no race between dropping a span's lock when it's in
the middle of finishing and the parent inserting that span into the
registry.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andreimatei
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 9, 2022

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Feb 10, 2022

Build succeeded:

@craig craig bot merged commit 0fdf716 into cockroachdb:master Feb 10, 2022
@andreimatei andreimatei deleted the tracing.comment branch February 10, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants