multitenant: listen for setting overrides #75711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
force-pushed
the
tenant-side-settings
branch
6 times, most recently
from
bf57142 to
5c06648
Compare
RaduBerinde
force-pushed
the
tenant-side-settings
branch
4 times, most recently
from
bfe29e7 to
8de0c61
Compare
RaduBerinde
commented
Feb 2, 2022
There was a problem hiding this comment.
Friendly ping.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @dt)
RaduBerinde
force-pushed
the
tenant-side-settings
branch
2 times, most recently
from
b960807 to
01d5134
Compare
ajwerner
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1, 18 of 18 files at r2, all commit messages.
Reviewable status:
pkg/ccl/kvccl/kvtenantccl/setting_overrides.go, line 85 at r2 (raw file):
if firstEventInStream && e.Incremental { return errors.Newf("first event must not be Incremental") }
This check happens here and above this call. The handling seems the same. Pick one? Maybe remove this one?
Code quote:
if firstEventInStream && e.Incremental {
return errors.Newf("first event must not be Incremental")
}
RaduBerinde
force-pushed
the
tenant-side-settings
branch
from
01d5134 to
b2d239b
Compare
RaduBerinde
commented
Feb 8, 2022
There was a problem hiding this comment.
TFTR!
Reviewable status:
This commit consolidates multiple uses of encoded setting values (raw value and type strings) into a `settings.EncodedValue` proto. The tenant settings roachpb API (not used yet) is updated to use this. Release note: None
This implements the tenant side code for setting overrides. Specifically, the tenant connector now implements the OverridesMonitor interface using the TenantSettings API. The server side of this API is not yet implemented, so this commit does not include end-to-end tests. Basic functionality is verified through a unit test that mocks the server-side API. Informs cockroachdb#73857. Release note: None
RaduBerinde
force-pushed
the
tenant-side-settings
branch
from
b2d239b to
af5a690
Compare
|
bors r+ |
|
Build succeeded: |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settings: add EncodedValue proto, update tenant settings API
This commit consolidates multiple uses of encoded setting values (raw
value and type strings) into a
settings.EncodedValueproto.The tenant settings roachpb API (not used yet) is updated to use this.
Release note: None
multitenant: listen for setting overrides
This implements the tenant side code for setting overrides.
Specifically, the tenant connector now implements the
OverridesMonitorinterface using theTenantSettingsAPI.The server side of this API is not yet implemented, so this commit
does not include end-to-end tests. Basic functionality is verified
through a unit test that mocks the server-side API.
Informs #73857.
Release note: None