Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: rename/upgrade xdg/scram -> xdg-go/scram #74510

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

knz
Copy link
Contributor

@knz knz commented Jan 6, 2022

Prereq for #74301

Release note: None

@knz knz requested a review from rafiss January 6, 2022 11:17
@knz knz requested review from a team as code owners January 6, 2022 11:17
@knz knz requested review from shermanCRL and removed request for a team January 6, 2022 11:17
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@shermanCRL shermanCRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything interesting here @HonoreDB?

@knz
Copy link
Contributor Author

knz commented Jan 6, 2022

Thanks matt.
If my reading is right, nothing changed in the upstream package besides the naming.

bors r=shermanCRL

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; but merge conflicts already cropped up

@knz knz force-pushed the 20210106-scram-deps branch from f968437 to 156f986 Compare January 6, 2022 16:46
@craig
Copy link
Contributor

craig bot commented Jan 6, 2022

Canceled.

@knz
Copy link
Contributor Author

knz commented Jan 6, 2022

thanks!

bors r=rafiss,shermanCRL

@rickystewart
Copy link
Collaborator

Pretty weird to me there are no changes to DEPS.bzl from this change, did you dev generate bazel --mirror?

@knz
Copy link
Contributor Author

knz commented Jan 6, 2022

Pretty weird to me there are no changes to DEPS.bzl from this change, did you dev generate bazel --mirror?

The new dependency was already mirrored somehow. I wasn't able to understand why, but it's there.

@knz
Copy link
Contributor Author

knz commented Jan 6, 2022

@rickystewart that reminds me, old/now-unused dependencies do not get removed from DEPS.bzl, is that expected?

@knz knz mentioned this pull request Jan 6, 2022
@craig
Copy link
Contributor

craig bot commented Jan 6, 2022

Build succeeded:

@craig craig bot merged commit 20ec845 into cockroachdb:master Jan 6, 2022
@knz knz deleted the 20210106-scram-deps branch January 6, 2022 17:54
craig bot pushed a commit that referenced this pull request Jan 6, 2022
67221: deps: update bufbuild/buf r=rickystewart a=knz

First commit from #74510.

Release note: None

Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants