Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: sql: make sql.defaults.reorder_joins_limit cluster setting public #73891

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

rytaft
Copy link
Collaborator

@rytaft rytaft commented Dec 16, 2021

Backport 1/1 commits from #73877.

/cc @cockroachdb/release


Release note (sql change): The cluster setting that controls the
default for the session setting reorder_joins_limit, called
sql.defaults.reorder_joins_limit, is now public and included in
the docs.


Release justification: Docs-only change

@rytaft rytaft requested review from rharding6373, RaduBerinde and a team December 16, 2021 03:27
@blathers-crl
Copy link

blathers-crl bot commented Dec 16, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (sql change): The cluster setting that controls the
default for the session setting reorder_joins_limit, called
sql.defaults.reorder_joins_limit, is now public and included in
the docs.
@rytaft rytaft force-pushed the backport21.1-73877 branch from b12e134 to 4d9e2e2 Compare December 16, 2021 03:33
@rytaft
Copy link
Collaborator Author

rytaft commented Dec 17, 2021

Friendly ping @rharding6373 @RaduBerinde

@rytaft rytaft merged commit 827dc79 into cockroachdb:release-21.1 Dec 17, 2021
@rytaft rytaft deleted the backport21.1-73877 branch December 17, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants