Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restoreccl: insert system.namespace entry for synthetic public schemas during restore #73875

Conversation

RichardJCai
Copy link
Contributor

@RichardJCai RichardJCai commented Dec 15, 2021

Release note (bug fix): Previously during restore we wouldn't insert a system.namespace
entry for synthetic public schemas.

Resolves #73535

@RichardJCai RichardJCai requested review from a team, miretskiy and dt and removed request for a team December 15, 2021 21:11
@cockroach-teamcity
Copy link
Member

This change is Reviewable

…s during restore

Release note (bug fix): Previously during restore we wouldn't insert a system.namespace
entry for synthetic public schemas.
@RichardJCai RichardJCai force-pushed the insert_public_schema_namespace_entry_on_restore branch from 6d32955 to 483e4d9 Compare December 16, 2021 16:59
@RichardJCai RichardJCai requested a review from a team December 16, 2021 16:59
@dt dt removed request for miretskiy, dt and a team December 17, 2021 01:44
@RichardJCai
Copy link
Contributor Author

TFTR!
bors r=dt

@craig
Copy link
Contributor

craig bot commented Dec 17, 2021

Build succeeded:

@craig craig bot merged commit 52b398f into cockroachdb:master Dec 17, 2021
@blathers-crl
Copy link

blathers-crl bot commented Dec 17, 2021

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 483e4d9 to blathers/backport-release-21.1-73875: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.1.x failed. See errors above.


error creating merge commit from 483e4d9 to blathers/backport-release-21.2-73875: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backupccl: restoring a database does not insert an entry for it's public schema in system.namespace
3 participants