cli: improve send-kv-batch help text and examples
#73602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
force-pushed
the
send-kv-batch-example
branch
from
fcf4f7b to
5a893cf
Compare
Release note: None
erikgrinaker
force-pushed
the
send-kv-batch-example
branch
from
5a893cf to
f33ce92
Compare
aliher1911
approved these changes
Dec 10, 2021
tbg
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
I have a follow-up PR on top of this commit, I'll send it when this is in.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker)
|
TFTRs! bors r=aliher1911,tbg |
|
Build succeeded: |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Dec 10, 2021
CRDB 21.2 already populates `Errors.EncodedError`, so we can remove the deprecated fields. I was motivated by this when working on a follow-up to cockroachdb#73602 and ended up trying to marshal an `Error` to JSON, which panics since it ends up trying to use `reflect` to get an unexported value (due to the `customname` tags on the deprecated fields). This behavior persists even with the `json: "-"` tag, by the way, indicating that we should never use `(gogoproto.customname)` to make a field private. It's also just one more papercut that comes with using `gogoproto` but that's a much bigger fish to fry. Release note: None
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Dec 10, 2021
CRDB 21.2 already populates `Errors.EncodedError`, so we can remove the deprecated fields. I was motivated by this when working on a follow-up to cockroachdb#73602 and ended up trying to marshal an `Error` to JSON, which panics since it ends up trying to use `reflect` to get an unexported value (due to the `customname` tags on the deprecated fields). This behavior persists even with the `json: "-"` tag, by the way, indicating that we should never use `(gogoproto.customname)` to make a field private. It's also just one more papercut that comes with using `gogoproto` but that's a much bigger fish to fry. Release note: None
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Dec 10, 2021
CRDB 21.2 already populates `Errors.EncodedError`, so we can remove the deprecated fields. I was motivated by this when working on a follow-up to cockroachdb#73602 and ended up trying to marshal an `Error` to JSON, which panics since it ends up trying to use `reflect` to get an unexported value (due to the `customname` tags on the deprecated fields). This behavior persists even with the `json: "-"` tag, by the way, indicating that we should never use `(gogoproto.customname)` to make a field private. It's also just one more papercut that comes with using `gogoproto` but that's a much bigger fish to fry. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None