*: use patched stringer instead of upstream #72704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
(Review only applies to most recent commit, the other is from #72699) |
rail
approved these changes
Nov 12, 2021
The patched `stringer` is identical to the upstream, except we don't paste the entire command-line into the generated file. This helps avoid spurious diffs when doing `dev build --hoist-generated-code`. See cockroachdb/tools@642e514 Release note: None
rickystewart
force-pushed
the
patchstringer
branch
from
0f59e21 to
403313f
Compare
|
bors r=rail |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patched
stringeris identical to the upstream, except we don'tpaste the entire command-line into the generated file. This helps avoid
spurious diffs when doing
dev build --hoist-generated-code.See cockroachdb/tools@642e514
Release note: None