backport-21.2: roachtest: fix cluster-init #70259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release justification: non-production code changes Release note: None
See discussion here; cockroachdb#67105 (comment) Release justification: non-production code changes Release note: None
Release justification: test-only change Release note: None
Give it a progress bar and a rudimentary context cancellation policy. Release justification: testing-only changes Release note: None
|
This change is |
|
Looks good to me, but the final merge is not my call. I would conservatively hold off on the merge until beta.1 is cut, on the argument that there is a change to a helper used throughout the test suite affected here, and a bug in it could produce fallout the investigation of which could delay the beta. I doubt this will actually happen but it's "cheap" to wait a week here. |
|
my mistake. it's issue #70186 . fixing PR description. |
tbg
approved these changes
Sep 27, 2021
|
Approved today by @isaactwong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70186 .
Release justification: non-production code changes
Release note: NoneBackport 4/4 commits from #69940.
/cc @cockroachdb/release