importccl: disallow IMPORT TABLE with expression indexes #67897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an explanatory error message when a user tries to execute an `IMPORT TABLE` statement with an expression index. Previously, the error confusingly read "unimplemented: only simple columns are supported as index elements". Now it reads "unimplemented: to import into a table with expression indexes, use IMPORT INTO". Release note: None
|
This change is |
adityamaru
approved these changes
Jul 22, 2021
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an explanatory error message when a user tries to
execute an
IMPORT TABLEstatement with an expression index.Previously, the error confusingly read "unimplemented: only simple
columns are supported as index elements". Now it reads "unimplemented:
to import into a table with expression indexes, use IMPORT INTO".
Release note: None