base: drop SlowRequestThreshold to 15s #67814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit drops `SlowRequestThreshold` from 60s to 15s. This constant dictates the delay before we consider the following four operations to be slow enough to log and/or increment "slow request" metrics: - raft proposals - raft proposal quota acquisition - lease acquisition - latch acquisition
|
This change is |
There was a problem hiding this comment.
I'm wondering if we want to just make this a cluster setting, with the new default being 15s.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @tbg)
tbg
approved these changes
Jul 21, 2021
In general, I agree 100% with the use of cluster settings, but this specific constant is used to construct a few static variables. So I'm going to take the easy/lazy path for now. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit drops
SlowRequestThresholdfrom 60s to 15s. This constantdictates the delay before we consider the following four operations to
be slow enough to log and/or increment "slow request" metrics: