proto movement #66692
Closed
proto movement #66692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@irfansharif I'm not sure this is worth the blast radius. I'm still in the process of cleaning it up but wanted to get a CI build in any case. |
irfansharif
reviewed
Jun 22, 2021
| @@ -73,13 +72,13 @@ type traceLogData struct { | |||
| // | |||
| // TODO(andrei): this should be unified with | |||
| // SessionTracing.generateSessionTraceVTable(). | |||
| func (r Recording) String() string { | |||
| if len(r) == 0 { | |||
| func RecordingToString(r *Recording) string { | |||
There was a problem hiding this comment.
(something I learned recently that you might find useful) PS: it's possible to define (gogoproto.goproto_stringer) = false; on proto types to override .String() with your own.
There was a problem hiding this comment.
ahhh, I googled for exactly this yesterday and came back empty-handed. Good to know!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.